New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create detekt-rules-ruleauthors
module
#5129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5129 +/- ##
============================
============================
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0264491
to
ec37d30
Compare
ec37d30
to
59f8919
Compare
|
||
override val ruleSetId: String = "detekt" | ||
|
||
override fun instance(config: Config) = RuleSet(ruleSetId, @Suppress("UseEmptyCounterpart") listOf()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:detekt-generator
relies in the fact that there is a listOf()
in this file. If I use emptyList()
it fails. This is an edge-transitory-case so I'm just Suppressing it. In the next PR I'll have a rule here so I'll remove @Suppress
59f8919
to
7da777b
Compare
I'm also not a big fan of the name. I would go for either
|
I didn't want to start it by Other option is to move these to another repo under the If we move it to another repo the name is not an issue anymore. We can call it |
Since we are at this: IMHO I think that having the assumtion that
That's also doable, but it really depends on how often we expect those rules to change. Maybe they can start off inside the Detekt repo and being moved outside in the future. |
Agree,
That have sense, true. So I'm renaming it to |
7da777b
to
31fd7ef
Compare
31fd7ef
to
a231471
Compare
039c063
to
0f8cb03
Compare
detekt-authors
moduledetekt-rules-ruleauthors
module
detekt-authors/src/main/kotlin/io/gitlab/arturbosch/detekt/authors/AuthorsProvider.kt
Outdated
Show resolved
Hide resolved
0f8cb03
to
f6692e1
Compare
f6692e1
to
6d37691
Compare
This is a new first-party detekt plugin for rules that only rule authors will need. In the next PR I'll add the first rule to this rule-set.
Any idea with the naming is more than welcome. I don't like
detekt-authors
too much butdetekt-detekt
seems even worst.